Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment parameter is not passed to __wbindgen_free in js bindings. #3638

Closed
Polish-Civil opened this issue Oct 2, 2023 · 1 comment · Fixed by #3639
Closed

Alignment parameter is not passed to __wbindgen_free in js bindings. #3638

Polish-Civil opened this issue Oct 2, 2023 · 1 comment · Fixed by #3639

Comments

@Polish-Civil
Copy link

Polish-Civil commented Oct 2, 2023 •
edited

wasm-bindgen/crates/cli-support/src/js/binding.rs

Line 1059 in f117406

"if ({ptr} !== 0) {{ wasm.{}({ptr}, {len}); }}",

I suppose it should pass in 4 by default.

Built with: --target wasm32-unknown-unknown -Z build -std=std,panic_abort
Generated binding with --web
@Polish-Civil Polish-Civil changed the title Aligment is not passed when deallocating cached strings, which is causing panics. Alignment parameter is not passed to __wbindgen_free in js bindings. Oct 2, 2023
@daxpedda
Copy link
Collaborator

daxpedda commented Oct 3, 2023

Indeed, it was missed in #3463.

@daxpedda daxpedda mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some calls to free() missing alignment daxpedda/wasm-bindgen
2 participants
@daxpedda @Polish-Civil