Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skipping .gitignore generation #728

Closed
RReverser opened this issue Oct 21, 2019 · 4 comments 路 May be fixed by #1131
Closed

Allow skipping .gitignore generation #728

RReverser opened this issue Oct 21, 2019 · 4 comments 路 May be fixed by #1131

Comments

@RReverser
Copy link
Member

馃挕 Feature description

Since implementing self-.gitignore generation in #473, I've come across few codebases that prefer not to publish npm artifacts elsewhere nor integrate Rust build into their build process, but keep any artifacts in the Git repo.

I suggest adding --no-gitignore option for such usecases.

Alternative

Since in such cases module is not intended to be published anywhere, another alternative could be to implement this (omit .gitignore) as part of --no-pack implementation proposed here #691.

cc @ashleygwilliams
@RReverser
Copy link
Member Author

Actually... I realised that this is easily worked around by using one-off git add --force pkg/... and it's even better because you can selectively include only files you need in the repo (e.g. omit package.json or .d.ts).

@David-OConnor
Copy link
Member

David-OConnor commented Oct 28, 2019 •
edited

I still think this would be nice to have.

@olanod
Copy link

olanod commented Jan 25, 2020

Same, I'd like to generate only the wasm and js and skip all the extra stuff since I'm not using npm

@aidanhs aidanhs mentioned this issue Mar 8, 2020
Closed
@acunniffe acunniffe mentioned this issue Jan 15, 2021
Merged
@johnnybenson
Copy link

johnnybenson commented Feb 25, 2022 •
edited

git add --force is kinda icky, .gitignore lives in a repository to codify these things for a reason. Skipping the generation of this file entirely scales better for multiple collaborators and teams because the appropriate information exists at rest.

@daggy1234 daggy1234 mentioned this issue May 1, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add skip-gitignore cli arg daggy1234/wasm-pack
4 participants
@johnnybenson @RReverser @olanod @David-OConnor