Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't check configuration w/o size_classes #71

Open
RReverser opened this issue Nov 29, 2018 · 0 comments
Open

CI doesn't check configuration w/o size_classes #71

RReverser opened this issue Nov 29, 2018 · 0 comments

Comments

@RReverser
Copy link
Member

As mentioned in #68, but for tracking separately:

size_classes is enabled by default, so one of the lines had to remain cargo check --release but another is supposed to be cargo check --release --no-default-features to test without size_classes enabled.

Hmm, looks like there is a bunch of other places in build.sh, check.sh, appveyor.yml that use --features size_classes.

@fitzgen Does this mean they are all similarly broken (testing same configuration as default) or am I missing some switch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant