Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of documentation #47

Open
basickarl opened this issue Mar 6, 2020 · 4 comments
Open

Lack of documentation #47

basickarl opened this issue Mar 6, 2020 · 4 comments

Comments

@basickarl
Copy link

basickarl commented Mar 6, 2020

What happens if git is not installed or that perhaps you are in a directory where git doesn't exist? What happens? What happens if the user isn't setup yet? etc.etc.etc.

Copy link
Owner

rwjblue commented Mar 10, 2020

Would love help documenting where you see things are missing.

RE: your specific questions:

What happens if git is not installed

This library does not rely on git executable, and git does not need to be installed at all.

you are in a directory where git doesn't exist?

I think if you execute in a directory that doesn't contain a .git subdirectory, it will error.

What happens if the user isn't setup yet?

Since we don't execute git at all, I don't think the user setup matters at all.

@basickarl
Copy link
Author

@rwjblue Ah ok, so it comes with it nice! Yea these things would be good to add to the documentation!

Ah yes true, if you use a username/password when pushing git will obviously use that account in the repo!

@ctsstc
Copy link

ctsstc commented Apr 20, 2020

@basickarl this does not use git to my knowledge, this uses the metadata stored in the files under the .git directory. Simple file parsing can be used to extract the state & information without the system needing to have git installed. It is also not included as a dependency in this package to my knowledge either.

Copy link
Owner

rwjblue commented May 7, 2020

ya, exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants