Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry logic will indefinitely retry #225

Open
nonken opened this issue Nov 18, 2017 · 0 comments
Open

Retry logic will indefinitely retry #225

nonken opened this issue Nov 18, 2017 · 0 comments

Comments

@nonken
Copy link

nonken commented Nov 18, 2017

When hitting Dynamo throttling limits (429s), Vogels will indefinitely retry and never back out.

https://github.com/ryanfitz/vogels/blob/master/lib/batch.js#L45-L47

The AWS-SDK attaches a retryable property to the error object for 500s and 429s.
This behaviour can bring hosts down as async.doWhilst will just retry forever. I think it is better to not handle retries at all and let the SDK handle this.

See also: #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant