You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ryanluker what was the issue? Why was the build expecting tslib when it wasn't present?
Edit: I did some reading and it seems like you would only need to manually build + install and test the extension when making changes to the tsconfig... this also seems like an edge case as I've never seen the need to install external libs which are not required directly by the code as runtime dependencies before.
@mattseddon No clue on the origin of the issue yet, and I agree that it might be overkill to manually build and install to test, definitely. I was just annoyed that we put out a release that caused regressions for folks when the test suite passing 😅.
The only thing that came to mind was the external extension dependency we have now, but I don't think that would cause us to need the tslib in the runtime deps...
Description
#370 Exposes an issue with how our unit and integration test works compared to the compiled extension code.
AC
The text was updated successfully, but these errors were encountered: