Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility of covered lines #419

Open
hak33m16 opened this issue Jul 22, 2023 · 4 comments
Open

Improve visibility of covered lines #419

hak33m16 opened this issue Jul 22, 2023 · 4 comments

Comments

@hak33m16
Copy link

hak33m16 commented Jul 22, 2023

Is your feature request related to a problem? Please describe.
Currently it's very difficult to see which lines are covered. The line is extremely thin and barely visible in the new 2.11.0 version. The lines on the left are the code coverage addon lines (the ones on the right are from a git addon displaying changes in the file since the last commit)
Screenshot 2023-07-21 at 10 58 43 PM

Describe the solution you'd like
It would be nice if the line was made thicker, or if the coverage was displayed directly on top of the contents of the files like it was previously. Right now it's very hard to visually see what my coverage is at

@mattseddon
Copy link
Collaborator

mattseddon commented Jul 25, 2023

Related to #407.

Hi @hak33m16,

Try setting the "coverage-gutters.showLineCoverage"/"coverage-gutters.showRulerCoverage" configuration options to true.

@hak33m16
Copy link
Author

Sure, I can try that once I'm on my work laptop again tomorrow. If this does fix it, is there a reason that isn't the default option? I remember this add-on used to show an outline on top of the text in the file, I would imagine it's not really useful to most if they can't actually see the coverage

The other thing is that the exact meaning of what those do isn't really documented in the extension page or the readme. I imagine this is actually a pretty big problem for people, and if you're opposed to having the coverage be visible by default, would it be helpful to explain those options in those places?

@mattseddon
Copy link
Collaborator

Feel free to open a PR with the suggested improvements and someone will take a look.

Thanks

@ryanluker
Copy link
Owner

@hak33m16 Thanks for the ticket and @mattseddon for the input!
I believe we saw this once before here, but it was a regression that went away after updating VS Code? The extension hasn't changed the visuals here in a long time (since we added colour blindness friendly defaults)

#407 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants