Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverb #161

Open
greenbech opened this issue Mar 6, 2022 · 3 comments
Open

Reverb #161

greenbech opened this issue Mar 6, 2022 · 3 comments

Comments

@greenbech
Copy link
Collaborator

I would like to have tunable global reverb when creating and playing music. I think this would be a killer feature anyways, but especially after #152 was merged I think it is even more important. Scoping this to be global (all tracks) would solve most usecases but in long term it would of course be nice to make it tunable to each track.

A good source of inspiration would be https://mmontag.github.io/chip-player-js/ (play a song -> click on 'Settings' and you will see reverb as a one of the parameters).

@ryohey
Copy link
Owner

ryohey commented Mar 8, 2022

Good point!
It seems to be relatively easy to implement by using WebAudio API's ConvolverNode. Also, reverb parameters exist in the MIDI specification as the control event (CC91). This control event can be set for each track, so it can be used as is.
I will implement this as a feature of wavelet.

@malinda666
Copy link

any updates on this? or explanations on how to do this?

@ryohey
Copy link
Owner

ryohey commented Apr 23, 2022

@malinda666 There is no progress due to lack of time. I am thinking of connecting a ConvolverNode to the output of the AudioWorkletNode provided by wavelet, so that its parameters can be controlled by CC91.
Or simply to make the sound more gorgeous, we could add a master reverb like in Chip Player JS and be able to set the amount on the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants