Skip to content

docs: "btn loading" is a breaking change #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxfriedmann opened this issue Jun 4, 2023 · 1 comment
Closed

docs: "btn loading" is a breaking change #1910

maxfriedmann opened this issue Jun 4, 2023 · 1 comment

Comments

@maxfriedmann
Copy link
Contributor

maxfriedmann commented Jun 4, 2023

On which page do you see this issue?

https://daisyui.com/docs/changelog/

Describe the issue

<button class="btn btn-primary loading"> does not work anymore as expected. We now should use <button class="btn btn-primary"><span class="loading loading-spinner"></button> which is fine, but not mentioned anywhere in the changelog. Also, adding the loading class to the btn seemed to disable the button before which is now missing.

We migrated to v3 and did not know about that change, so all loading buttons were broken. I just think it would be great to mention that in the changelogs so that others don't run into the same issue.

💖 Great new version btw. 💖

What browsers are you seeing the problem on?

Chrome, Firefox, Edge

@maxfriedmann
Copy link
Contributor Author

wonderful, thx!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant