Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --plugin functionality to add extra TSLint or ESLint plugins #20

Open
5 tasks
saadq opened this issue Jun 22, 2018 · 0 comments
Open
5 tasks

Add --plugin functionality to add extra TSLint or ESLint plugins #20

saadq opened this issue Jun 22, 2018 · 0 comments
Labels
enhancement New feature or request. good first issue Good for newcomers.

Comments

@saadq
Copy link
Owner

saadq commented Jun 22, 2018

v0.4 allows for rule overrides, however the only rules you can add on are the standard ESLint/TSLint rules as well as rules for the plugins that are shipped with lynt (eslint-plugin-flowtype, eslint-plugin-react, tslint-microsoft-contrib, and tslint-react).

What would need to be done:

  • Add a plugins field to the Options interface which would be string | Array<string>
  • Add a plugin flag to the CLI (with a plugins alias and update the help text)
  • Check if plugins exists on the options object for both ESLint and TSLint. If it exists, combine options.plugins with config.plugins.
  • Add a test in tests/config.ts (for both ESLint and TSLint) to make sure that the output config does contain options.plugins.
  • Add a test for both ESLint and TSLint in tests/api.ts that calls lynt with plugins and rules (rules from the plugin) passed to options. You can look at the other test cases as reference.

Let me know if anyone would be interested in taking this on! I'd be happy to help along the way.

@saadq saadq added enhancement New feature or request. good first issue Good for newcomers. labels Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. good first issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

1 participant