Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to Website #138

Closed
smainz opened this issue Jun 16, 2021 · 23 comments
Closed

Deploy to Website #138

smainz opened this issue Jun 16, 2021 · 23 comments
Assignees

Comments

@smainz
Copy link
Contributor

smainz commented Jun 16, 2021

In April my PR #134 regarding outdated docker install instructions has been accepted, but on the Website there still is the old version.

Can anyone please depoy this?

@staabm
Copy link
Member

staabm commented Jun 16, 2021

@DominikTo I guess you are the only one with the required credentials

@DominikTo
Copy link
Member

Ah, damn. That reminds me that I wanted to automate this. Will trigger a deploy shortly and report back here.

@DominikTo
Copy link
Member

Done.

@smainz
Copy link
Contributor Author

smainz commented Jun 18, 2021

Thanks

@DeepDiver1975
Copy link
Member

Ah, damn. That reminds me that I wanted to automate this.

Any news on automation? Has this been taken care of?
Also to reduce the bus factor here: who else can do the deployment? THX

@DominikTo
Copy link
Member

Will take care of it.

@DeepDiver1975
Copy link
Member

Will take care of it.

THX a lot - as an more open approach we could move the site over to github pages.

I can look into the technical side if this is of interest.

@phil-davis
Copy link
Contributor

@DominikTo does the web site auto-deploy these days when this repo changes?
(I will make some small change anyway, and see if any "magic" happens)

@DominikTo
Copy link
Member

It sadly does not and I didn't get around yet to get the deploy script up and running locally again.

@DeepDiver1975
Copy link
Member

due to #157 we have an autodeployed site again on https://sabre-io.github.io/sabre.io/

@DominikTo let's chat on how to redirect https://sabre.io to github pages - thx

@staabm
Copy link
Member

staabm commented Nov 9, 2023

having it as a github pages site is perfect, thank you!

@DeepDiver1975
Copy link
Member

if we are fine to have it pure under https://sabre-io.github.io/sabre.io/ - some hard coded links within the source code need adaptation.

@ByteHamster
Copy link
Member

Doesn't that break external links, search engines, etc? Can't we set the dns of sabre.io to GitHub, so it stays on the same domain?

@DeepDiver1975
Copy link
Member

We for sure can do that....
We = @DominikTo

@DominikTo
Copy link
Member

Oh this is great! The old deploy script would have needed quite significant updates to work again.
Let me check on setting up the domain for GH pages.

@DominikTo
Copy link
Member

@DeepDiver1975:

DNS is now hooked up for this repo/org.
But GH UI added the CNAME file to the gh-pages branch when adding the domain, guess that should move into the master branch, so it gets added for deploys. And seems like links need to be updated. On the currently live page all links go to the github.io URL instead of sabre.io

@DeepDiver1975
Copy link
Member

And seems like links need to be updated. On the currently live page all links go to the github.io URL instead of sabre.io

yes - will take care asap

@DeepDiver1975
Copy link
Member

But GH UI added the CNAME file to the gh-pages branch when adding the domain, guess that should move into the master branch, so it gets added for deploys.

will have a look as well ....

@DeepDiver1975
Copy link
Member

@DominikTo
Copy link
Member

Yes, but interestingly enough the UI did not give me a TXT record for verification.
Saw "DNS verified" straight away and it committed the CNAME file into the gh-pages branch.

If non-async is easier: Available via Twitter DM or on Matrix.

@DominikTo
Copy link
Member

Just realized that adding domain to GH pages and verifying are two separate processes.
Now also verified for sabre-io org.

@phil-davis
Copy link
Contributor

I tried fixing something in the docs - PR #164
It was published on merge correctly, good.
So we are able to update documentation and publish it nowadays.

@phil-davis
Copy link
Contributor

This seems to be working. So I will close the issue. Feel free to re-open if there is more needed to be done.

(of course the actual docs content needs to be got up-to-date, but that is a separate task!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants