force is not very self-explaining

[thomaseizinger]

Problem Description

The force argument of a task is not very self-explaining. I had to check the documentation on what it does.

Maybe a name like allow_failure or ignore_failure could express the intent more clearly?

Code Example

[tasks.cleanup-cache]
allow_failure = true
script = ["..."]

[sagiegurari]

agree allow_failure is much better and self explanatory, I kinda reused the 'force' name from other tools I saw such as gruntjs.
unfortunately, changing this would be a real backward break and i'm not sure its important enough to justify it.

[thomaseizinger]

You could break it with 1.0. IMO situations like these are the reason why we have pre-1.0 releases :) But, obviously it is totally up to you! Also, I guess that the use of force = true is rather rare. Maybe 1 or 2 per codebase? Fixing that takes literally 10 seconds if the error message is good :)

…

On Mon, 29 Oct 2018, 20:07 Sagie Gur-Ari, ***@***.***> wrote: agree allow_failure is much better and self explanatory, I kinda reused the 'force' name from other tools I saw such as gruntjs. unfortunately, changing this would be a real backward break and i'm not sure its important enough to justify it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#120 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFO3NRTwjvXx9AnuGpCT-CjcESG4e9yJks5upsVugaJpZM4X-oSn> .

[sagiegurari]

fixing takes little time, understanding why takes longer and it would increase user frustration. I'll think about it. for now I'm keeping this item open.

[thomaseizinger]

That is why I added "if the error message is good"! Was thinking about something like The attribute 'force' has been replaced with 'allow_failure'. Please update your configuration.

Thanks for considering it! :)

[sagiegurari]

@thomaseizinger I decided to go for it. I renamed it to ignore_errors.
right now both attributes are supported and if force is used, it will have the error message you suggested.

[sagiegurari]

@thomaseizinger published 0.16.8 so closing this issue.
if there is anything else, please open a new issue.

[thomaseizinger]

Awesome!
Thank you for making cargo-make and putting so much effort in into it!