Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format check and clippy to ci-flow #161

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Add format check and clippy to ci-flow #161

merged 1 commit into from
Dec 10, 2018

Conversation

D4nte
Copy link
Contributor

@D4nte D4nte commented Dec 9, 2018

  • env CARGO_MAKE_CLIPPY added
  • env CARGO_MAKE_CHECK_FORMAT added

@D4nte D4nte mentioned this pull request Dec 9, 2018
Closed
@sagiegurari
Copy link
Owner

thanks.
can you prefix both env vars as 'CARGO_MAKE_RUN_' for example CARGO_MAKE_RUN_CLIPPY?
also do not use the pre hooks, I leave those emtpy so users can override them.
instead just add to the ci-flow dependencies, like bench-ci-flow and examples-ci-flow

@codecov-io
Copy link

codecov-io commented Dec 10, 2018 •
edited

Codecov Report

Merging #161 into 0.16.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.16.0     #161   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          55       55           
  Lines        8676     8676           
=======================================
  Hits         8166     8166           
  Misses        510      510

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb50c8e...6b74e9e. Read the comment docs.

@D4nte
Copy link
Contributor Author

D4nte commented Dec 10, 2018

Comments implemented.

@D4nte D4nte force-pushed the add-chk-fmt-to-ci branch 2 times, most recently from e73672d to 0f0453b Compare December 10, 2018 03:58
Add format check and clippy to ci-flow
6b74e9e 
* env CARGO_MAKE_RUN_CLIPPY added
* env CARGO_MAKE_RUN_CHECK_FORMAT added
@sagiegurari
Copy link
Owner

looks good!! let's just eait for the build to validate and I'll merge it in.
thanks

@sagiegurari sagiegurari merged commit 6bab240 into sagiegurari:0.16.0 Dec 10, 2018
@sagiegurari
Copy link
Owner

merged. thanks @D4nte

@D4nte D4nte deleted the add-chk-fmt-to-ci branch December 10, 2018 23:19
@D4nte
Copy link
Contributor Author

D4nte commented Dec 11, 2018

@sagiegurari do I then need to push to master? how do you manage your branches?

sagiegurari added a commit that referenced this pull request Jan 7, 2019
@sagiegurari
document Azure Pipelines config #161
c3f533d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagiegurari sagiegurari sagiegurari left review comments

Assignees

@D4nte D4nte

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@D4nte @sagiegurari @codecov-io