Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kcov version validation #203

Closed
sagiegurari opened this issue Mar 17, 2019 · 3 comments
Closed

add kcov version validation #203

sagiegurari opened this issue Mar 17, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@sagiegurari
Copy link
Owner

Describe the bug
base on #201 If kcov 33 is already installed, cargo-make will not reinstall kcov.
however 33 doesn't support few features that are needed.
So need to add version validation as well.

@ssokolow
Copy link

I haven't let the task go all the way yet, but attempting to run makers coverage-kcov with my current kcov 33 does now display a sudo prompt rather than failing with an error.

@sagiegurari
Copy link
Owner Author

which means it works as it should.
cargo make will attempt to install anything that is missing and in kcov case also if it sees that it doesn't support the needed features.
when installing kcov i need sudo permission which is the prompt you got.
once you put in the password, it will install kcov and invoke it.
next run, it will just work.

if it would fail with an error, it means you need to manually repair kcov which is not what i want.

@ssokolow
Copy link

Yeah. What I meant to communicate was "The version check is working as intended, but I won't know if the whole installation process completes successfully until tomorrow, when I audit the contents of the task before giving it my password."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants