Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More relaxed CARGO_MAKE_TEST_COVERAGE_DEFAULT_BINARY_FILTER #230

Closed
orenbenkiki opened this issue May 19, 2019 · 3 comments
Closed

More relaxed CARGO_MAKE_TEST_COVERAGE_DEFAULT_BINARY_FILTER #230

orenbenkiki opened this issue May 19, 2019 · 3 comments
Assignees
Milestone

Comments

@orenbenkiki
Copy link

Currently:

CARGO_MAKE_TEST_COVERAGE_DEFAULT_BINARY_FILTER = "${CARGO_MAKE_CRATE_FS_NAME}-[a-z0-9]*$\\|test_[a-z0-9]*-[a-z0-9]*$\\|[a-z0-9]*_test-[a-z0-9]*$"

This does not capture my test_union_find.rs tests, because of the regexps test_[a-z0-9]*. Given Rust naming convention, it is reasonable to restrict test file names, to avoid capital letters and Unicode insanity. However, there's no good reason to avoid _:

CARGO_MAKE_TEST_COVERAGE_DEFAULT_BINARY_FILTER = "${CARGO_MAKE_CRATE_FS_NAME}-[a-z0-9]*$\\|test_[_a-z0-9]*-[a-z0-9]*$\\|[a-z0-9]*_test-[_a-z0-9]*$"
@sagiegurari
Copy link
Owner

makes sense. will check it.

@sagiegurari
Copy link
Owner

@orenbenkiki update pushed to development branch.

@orenbenkiki
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants