Clippy on ci-flow with -D warnings

[elpiel]

Hello,
It's more of a question for discussion whether the clippy task should fail on any warnings. Maybe this can also be controlled with an env. variable?

E.g.
args = ["clippy", "--all-features", "--", "-D", "warnings"]

[sagiegurari]

I think that's really good idea.
with the help of the split function I could have a default empty env var and users could modify that env var to whatever args they want to add.

you can today just override that task, and set the args only.

[elpiel]

Yes, that's what I did, but for the CI flow I thought it's a good idea to actually fail the build on such occasions. And I wanted to hear your thoughts on that.

[sagiegurari]

I'm thinking of doing something like the following:

[env]
CARGO_MAKE_CLIPPY_ALL_FEATURES_WARN = "--all-features -- -D warnings"
CARGO_MAKE_CLIPPY_NO_ARGS = "--all-features -- -D warnings"
CARGO_MAKE_CLIPPY_ARGS = "${CARGO_MAKE_CLIPPY_NO_ARGS}"

[tasks.clippy]
description = "Runs clippy code linter."
category = "Test"
dependencies = [
    "install-clippy"
]
command = "cargo"
args = ["clippy", "@@split(CARGO_MAKE_CLIPPY_ARGS, )"]

this will basically mean that by default, clippy is invoked without any args like today.
but you could change to all features+warn by doing the following:

[env]
CARGO_MAKE_CLIPPY_ARGS = "${CARGO_MAKE_CLIPPY_ALL_FEATURES_WARN }"

in your makefile.
and if you wish to enable it for a specific profile only, you can do it as follows:

[env.ci]
CARGO_MAKE_CLIPPY_ARGS = "${CARGO_MAKE_CLIPPY_ALL_FEATURES_WARN }"

and run it

cargo make --profile ci

[elpiel]

Sounds good to me. I will try to sit down today and fire a PR 😊

[sagiegurari]

actually this one i already developed (i took the example from what i did and tested).
but you could do a pr to the other issue you opened, but i would prefer there a bit better shell script solution if possible

[elpiel]

@sagiegurari when can I expect this to be committed & released, so that I can check it and close this issue?

[sagiegurari]

i actually pushed it to 0.19.5 branch 2 minutes ago.
so you can check it now if you install it from github directly

[elpiel]

Tested it today. Works perfectly! Thanks!

[sagiegurari]

thanks for confirming!!!