Guard against self-referential aliases #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unfortunately, there are endless ways to get into infinite loop. |
When resolving task aliases, keep track of aliases that were
already considered and error out when an already resolved alias
is hit again.
Example Makefile.toml:
## error:
## thread 'main' has overflowed its stack
## fatal runtime error: stack overflow
## Aborted (core dumped)
[tasks.rec]
alias = "rec"
[tasks.rec-mut-a]
alias = "rec-mut-b"
[tasks.rec-mut-b]
alias = "rec-mut-a"
To aid debugging the error message shows the complete cycle:
Detected cycle while resolving alias rec-mut-b: rec-mut-a -> rec-mut-b
phi-gamma
force-pushed
the
self-referential-alias
branch
from
65a76aa
to
e706ae5
Compare
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
- Coverage 93.38% 93.38% -0.01%
==========================================
Files 86 86
Lines 14910 14945 +35
==========================================
+ Hits 13924 13956 +32
- Misses 986 989 +3
Continue to review full report at Codecov.
|
I just realized that as well, see the updated commit. |
|
great stuff!!! thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving task aliases, error out if the alias matches the
name of the current task to prevent infinite recursion:
Example Makefile.toml: