Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass profiles in workspaces. #309

Merged
merged 6 commits into from
Nov 10, 2019
Merged

Pass profiles in workspaces. #309

merged 6 commits into from
Nov 10, 2019

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Nov 9, 2019

Added a setting to enable passing down profiles to workspace members.

  • Is the name CARGO_MAKE_PASS_PROFILE alright?
  • Any improvements to the description in the documentation are welcome.

cc #263.

This variable lets `cargo-make` pass down profiles for workspaces.
Copy link
Owner

@sagiegurari sagiegurari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot of fixing this issue.
i think your change will be a default behavior, but its good its gated with an env var to enable users to decide.

docs/_includes/content.md Outdated Show resolved Hide resolved
src/lib/execution_plan.rs Outdated Show resolved Hide resolved
@sagiegurari sagiegurari changed the base branch from master to 0.23.1 November 9, 2019 13:08
@sagiegurari sagiegurari added this to the 0.23.1 milestone Nov 9, 2019
@codecov-io
Copy link

codecov-io commented Nov 9, 2019

Codecov Report

Merging #309 into 0.24.0 will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.0     #309      +/-   ##
==========================================
- Coverage   93.11%   93.11%   -0.01%     
==========================================
  Files          86       86              
  Lines       14894    14895       +1     
==========================================
  Hits        13869    13869              
- Misses       1025     1026       +1
Impacted Files Coverage Δ
src/lib/execution_plan_test.rs 95.18% <ø> (ø) ⬆️
src/lib/environment/mod.rs 96.01% <100%> (-0.04%) ⬇️
src/lib/execution_plan.rs 92.3% <75%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5334ffb...0fc31d3. Read the comment docs.

@sagiegurari
Copy link
Owner

@daxpedda i want this to be default behavior so created a new branch and deleted old dev branch.
it caused the PR to close. sorry!!!

@sagiegurari sagiegurari reopened this Nov 9, 2019
@sagiegurari sagiegurari changed the base branch from 0.23.1 to 0.24.0 November 9, 2019 14:32
@sagiegurari
Copy link
Owner

merged. thanks a lot.
i'll probably change this to default behavior with ability to turn it off as this fix is really important.

@sagiegurari sagiegurari merged commit 03e52f7 into sagiegurari:0.24.0 Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants