-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass profiles in workspaces. #309
Conversation
This variable lets `cargo-make` pass down profiles for workspaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot of fixing this issue.
i think your change will be a default behavior, but its good its gated with an env var to enable users to decide.
Codecov Report
@@ Coverage Diff @@
## 0.24.0 #309 +/- ##
==========================================
- Coverage 93.11% 93.11% -0.01%
==========================================
Files 86 86
Lines 14894 14895 +1
==========================================
Hits 13869 13869
- Misses 1025 1026 +1
Continue to review full report at Codecov.
|
@daxpedda i want this to be default behavior so created a new branch and deleted old dev branch. |
merged. thanks a lot. |
Added a setting to enable passing down profiles to workspace members.
CARGO_MAKE_PASS_PROFILE
alright?cc #263.