Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CARGO_MAKE_WORKING_DIRECTORY. #311

Merged
merged 3 commits into from
Nov 10, 2019
Merged

Add CARGO_MAKE_WORKING_DIRECTORY. #311

merged 3 commits into from
Nov 10, 2019

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Nov 9, 2019

Fixes #310.

@codecov-io
Copy link

codecov-io commented Nov 9, 2019

Codecov Report

Merging #311 into 0.24.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.0     #311      +/-   ##
==========================================
+ Coverage   93.11%   93.11%   +<.01%     
==========================================
  Files          86       86              
  Lines       14890    14894       +4     
==========================================
+ Hits        13865    13869       +4     
  Misses       1025     1025
Impacted Files Coverage Δ
src/lib/environment/mod.rs 96.05% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e501868...506ec22. Read the comment docs.

@daxpedda
Copy link
Contributor Author

Do you want me to move this PR to the 0.24.0 branch?

@sagiegurari sagiegurari changed the base branch from master to 0.24.0 November 10, 2019 11:44
@sagiegurari sagiegurari added this to the 0.24.0 milestone Nov 10, 2019
@sagiegurari
Copy link
Owner

thanks for the PR. this looks great.
i already switched the base branch.
will probably merge both your PRs today/tomorrow.

@sagiegurari sagiegurari merged commit 5334ffb into sagiegurari:0.24.0 Nov 10, 2019
@sagiegurari
Copy link
Owner

merged. thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants