Add CARGO_MAKE_WORKSPACE_INCLUDE_MEMBERS.
#316
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.24.0 #316 +/- ##
=========================================
Coverage ? 93.14%
=========================================
Files ? 86
Lines ? 15001
Branches ? 0
=========================================
Hits ? 13973
Misses ? 1028
Partials ? 0
Continue to review full report at Codecov.
|
src/lib/execution_plan.rs
Outdated
| @@ -120,6 +120,26 @@ fn should_skip_workspace_member(member: &str, skipped_members: &HashSet<String>) | |||
| } | |||
| } | |||
|
|
|||
| fn get_included_workspace_members(include_members_config: String) -> Option<HashSet<String>> { | |||
| let list = get_skipped_workspace_members(include_members_config); | |||
There was a problem hiding this comment.
this is a bit unreadable to me.
maybe we can have a single function like is_workspace_member_found(member, members_map) -> bool
and then should_skip_workspace_member calls it and if found returns skip and should_include_workspace_member calls it and if found returns include.
same logic should also be for get_skipped_workspace_members and get_included_workspace_members.
There was a problem hiding this comment.
Done. Did I get it right?
README.md
Outdated
| CARGO_MAKE_WORKSPACE_INCLUDE_MEMBERS = "tools/*" | ||
| ``` | ||
|
|
||
| This works together with **CARGO_MAKE_WORKSPACE_SKIP_MEMBERS**, members who are skipped will not be included. |
There was a problem hiding this comment.
This works together with CARGO_MAKE_WORKSPACE_SKIP_MEMBERS, members which are excluded.
There was a problem hiding this comment.
I tried to include that including members doesn't not ignore rules set by skipping members. Please feel free to modify it.
This works together with CARGO_MAKE_WORKSPACE_SKIP_MEMBERS, which will still exclude members and not be overwritten by CARGO_MAKE_WORKSPACE_INCLUDE_MEMBERS.
|
looks great. thanks a lot for all your PRs. |
|
Thanks for creating and maintaining this great project!
I will, thanks. |
I think I managed to add a working test this time, might be more rigorous though.
The documentation has to be regenerated, didn't manage to get that working.
Fixes #315.