Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand environment variables in tasks.cwd #318

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Expand environment variables in tasks.cwd #318

merged 3 commits into from
Nov 12, 2019

Conversation

daxpedda
Copy link
Contributor

This is potentially a breaking change, I marked it as such in the changelog.

Fixes #317.

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #318 into 0.24.0 will increase coverage by 0.8%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           0.24.0     #318     +/-   ##
=========================================
+ Coverage   92.32%   93.13%   +0.8%     
=========================================
  Files          86       86             
  Lines       15388    14959    -429     
=========================================
- Hits        14207    13932    -275     
+ Misses       1181     1027    -154
Impacted Files Coverage Δ
src/lib/runner.rs 92.74% <100%> (ø) ⬆️
src/lib/cli_commands/diff_steps_test.rs 89.85% <0%> (-0.94%) ⬇️
src/lib/cli_commands/print_steps_test.rs 92.15% <0%> (-0.3%) ⬇️
src/lib/runner_test.rs 90.1% <0%> (-0.27%) ⬇️
src/lib/execution_plan_test.rs 95.11% <0%> (-0.2%) ⬇️
src/lib/condition_test.rs 92.7% <0%> (-0.1%) ⬇️
src/lib/environment/mod.rs 96.39% <0%> (-0.09%) ⬇️
src/lib/types_test.rs 95.66% <0%> (-0.07%) ⬇️
src/lib/types.rs 86.2% <0%> (+0.25%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5156729...442f0ff. Read the comment docs.

src/lib/runner.rs Outdated Show resolved Hide resolved
@sagiegurari
Copy link
Owner

thanks. this makes a lot of sense.

@sagiegurari
Copy link
Owner

looks great. merging. thanks a lot

@sagiegurari sagiegurari merged commit a3f6670 into sagiegurari:0.24.0 Nov 12, 2019
@daxpedda daxpedda deleted the expand-cwd branch November 12, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants