"CARGO_MAKE_WORKSPACE_WORKING_DIRECTORY" does not behave as described in emulated workspace

[connorkuehl]

Describe the bug

The documentation describes this environment variable as the working directory of the workspace root:

CARGO_MAKE_WORKSPACE_WORKING_DIRECTORY - The original working directory of the workspace. Enables workspace members access to the workspace level CARGO_MAKE_WORKING_DIRECTORY.

However, in an emulated workspace, this environment variable becomes the directory of the member crate.

In a non-emulated workspace, the environment variable is correct.

To Reproduce
Steps to reproduce the behavior:

1. Create a directory to serve as the workspace (mkdir workspace-wd)
2. Create member crates (cargo new --bin member1; cargo new --lib member2)
3. Create a Makefile.toml in the workspace root:

[env]
CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE = "true"
CARGO_MAKE_WORKSPACE_EMULATION = true
CARGO_MAKE_CRATE_WORKSPACE_MEMBERS = ["member1", "member2"]

[tasks.root]
command = "echo"
args = ["${CARGO_MAKE_WORKSPACE_WORKING_DIRECTORY}"]

4. From the example above, run the root task.

Actual result:

$ cargo make root
[cargo-make] INFO - cargo make 0.31.0
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: root
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: workspace
[cargo-make][1] INFO - External file not found or is not a file, skipping.
[cargo-make][1] INFO - Project: member1
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: root
[cargo-make][1] INFO - Profile: development
[cargo-make][1] INFO - Running Task: root
[cargo-make][1] INFO - Execute Command: "echo" "/tmp/workspace-wd/member1"
/tmp/workspace-wd/member1
[cargo-make][1] INFO - Build Done in 0 seconds.
/tmp/workspace-wd
[cargo-make][1] INFO - External file not found or is not a file, skipping.
[cargo-make][1] INFO - Project: member2
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: root
[cargo-make][1] INFO - Profile: development
[cargo-make][1] INFO - Running Task: root
[cargo-make][1] INFO - Execute Command: "echo" "/tmp/workspace-wd/member2"
/tmp/workspace-wd/member2
[cargo-make][1] INFO - Build Done in 0 seconds.
/tmp/workspace-wd
[cargo-make] INFO - Build Done in 0 seconds.

Expected result:

$ cargo make root
[cargo-make] INFO - cargo make 0.31.0
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: root
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: workspace
[cargo-make][1] INFO - External file not found or is not a file, skipping.
[cargo-make][1] INFO - Project: member1
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: root
[cargo-make][1] INFO - Profile: development
[cargo-make][1] INFO - Running Task: root
[cargo-make][1] INFO - Execute Command: "echo" "/tmp/workspace-wd"
/tmp/workspace-wd
[cargo-make][1] INFO - Build Done in 0 seconds.
/tmp/workspace-wd
[cargo-make][1] INFO - External file not found or is not a file, skipping.
[cargo-make][1] INFO - Project: member2
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: root
[cargo-make][1] INFO - Profile: development
[cargo-make][1] INFO - Running Task: root
[cargo-make][1] INFO - Execute Command: "echo" "/tmp/workspace-wd"
/tmp/workspace-wd
[cargo-make][1] INFO - Build Done in 0 seconds.
/tmp/workspace-wd
[cargo-make] INFO - Build Done in 0 seconds.

[sagiegurari]

thanks a lot for the detailed explanation.
I'll take a look at it.

[sagiegurari]

@connorkuehl can you try the 0.31.1 branch version and see if it solves your issues?

[connorkuehl]

@connorkuehl can you try the 0.31.1 branch version and see if it solves your issues?

Works great! Thank you 😄

[sagiegurari]

I published an official release so i think we can close this one.
thanks a lot for the feedback.