-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for explicit workspace flow in sub flows #455
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.32.5 #455 +/- ##
==========================================
+ Coverage 92.63% 92.80% +0.17%
==========================================
Files 92 92
Lines 17886 17797 -89
==========================================
- Hits 16568 16516 -52
+ Misses 1318 1281 -37
Continue to review full report at Codecov.
|
@epontan thanks a lot for the PR, it looks good. |
@sagiegurari thank you! It looks like all passed except the code coverage this time. I'm not sure why it fails. If I run coverage-tarpaulin locally the coverage is increased by half a point. |
ya, its due to rustfmt compilation broken on nightly. just pushed a workaround, let me restart the GH actions and see how it goes. |
@epontan can you pull 032.5 changes to your local branch? this will contain the rustfmt workaround so we can see coverage is ok |
Commit fa929b1 ("Fix workspace detection for sub flows") caused a regression when having a root workspace with tasks that relies on each member to define CARGO_MAKE_CARGO_BUILD_TEST_FLAGS with unique set of features. Determine if workspace flow is explicitly set in the task when planning the execution and take this setting into account when running in a sub flow.
fa44be7
to
1176842
Compare
@sagiegurari that seemed to have done the trick! Thanks 👍 |
@epontan this is really great fix. thanks a lot!!! |
Commit fa929b1 ("Fix workspace detection for sub flows") caused a
regression when having a root workspace with tasks that relies on each
member to define CARGO_MAKE_CARGO_BUILD_TEST_FLAGS with unique set of
features.
Determine if workspace flow is explicitly set in the task when planning
the execution and take this setting into account when running in a sub
flow.