Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for env_files loading #459

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

wolf4ood
Copy link
Contributor

Hi,
i found out that when loading env_files with profiles , if a profile is not matched the loading process is interrupted and the eventual other files in the list are skipped.

In order to show this behaviour i've created the test set_env_files_for_config_profile_inverse by copying set_env_files_for_config_profile inverting the positions of the two files in the test.

I'm not sure if it's a wanted behaviour or a bug. In case of a bug in this PR there is the fix

Thanks :)

@wolf4ood wolf4ood changed the title added fix for env_files loading Fix for env_files loading Sep 26, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2020

Codecov Report

Merging #459 into master will increase coverage by 0.00%.
The diff coverage is 93.02%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          92       92           
  Lines       17929    17957   +28     
=======================================
+ Hits        16599    16626   +27     
- Misses       1330     1331    +1     
Impacted Files Coverage Δ
src/lib/environment/mod_test.rs 96.07% <92.59%> (-0.10%) ⬇️
src/lib/environment/mod.rs 89.02% <93.75%> (ø)
src/lib/runner.rs 80.38% <0.00%> (-0.22%) ⬇️
src/lib/descriptor/mod.rs 86.52% <0.00%> (+0.25%) ⬆️
src/lib/environment/crateinfo.rs 84.88% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e82c0...3152112. Read the comment docs.

@sagiegurari sagiegurari changed the base branch from master to 0.32.6 September 28, 2020 16:52
@sagiegurari
Copy link
Owner

@wolf4ood thanks a lot for the fix. its a definite bug :)
merging

@sagiegurari sagiegurari merged commit 8b5cb81 into sagiegurari:0.32.6 Sep 28, 2020
@wolf4ood wolf4ood deleted the fix_env_files_loading branch September 29, 2020 07:52
@sagiegurari sagiegurari added this to the 0.32.6 milestone Oct 1, 2020
@sagiegurari sagiegurari added the bug label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants