Provide more detailed error message when env-script fails #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's really great. Let me check the code out. |
sagiegurari
reviewed
Oct 1, 2020
src/lib/environment/mod.rs
Outdated
Comment on lines
46
to
47
| "stdout: \"{}\"\n", | ||
| "stderr: \"{}\"" |
There was a problem hiding this comment.
can we drop the wrapper " here? its a bit confusing in the output.
we can do
stdout:\n{}\n
stderr:\n{}\n
instead. wdyt?
There was a problem hiding this comment.
Sure, I couldn't really decide one ideal output format anyway.
src/lib/environment/mod.rs
Outdated
| error!( | ||
| concat!( | ||
| "Error while evaluating script for env: {}, exit code: {}\n", | ||
| "script: {:#?}\n", |
There was a problem hiding this comment.
can we change this one to
script:\n{:#?}\n
Codecov Report
@@ Coverage Diff @@
## 0.32.6 #463 +/- ##
===========================================
+ Coverage 64.91% 92.61% +27.70%
===========================================
Files 92 92
Lines 18049 18057 +8
===========================================
+ Hits 11717 16724 +5007
+ Misses 6332 1333 -4999
Continue to review full report at Codecov.
|
epontan
force-pushed
the
show-failed-env-script
branch
from
1bea729
to
3f42fdb
Compare
There is limited information given in the error output when an
env-script return a non-zero exit code, which can be quite confusing as
there is no context of where it failed (unless verbose output is turned
on).
Avoid confusion by providing more context about the environment when the
script fails.
BEFORE:
> cargo make
[cargo-make] INFO - cargo make 0.32.5
[cargo-make] ERROR - Error while executing command, exit code: 128
[cargo-make] WARN - Build Failed.
AFTER:
> cargo make
[cargo-make] INFO - cargo make 0.32.5
[cargo-make] ERROR - Error while evaluating script for env: GIT_ROOT, exit code: 128
script:
[
"git rev-parse --show-toplevel",
]
stdout:
stderr:
fatal: not a git repository (or any of the parent directories): .git
[cargo-make] WARN - Build Failed.
epontan
force-pushed
the
show-failed-env-script
branch
from
3f42fdb
to
76364b2
Compare
|
Looks great @epontan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is limited information given in the error output when an
env-script return a non-zero exit code, which can be quite confusing as
there is no context of where it failed (unless verbose output is turned
on).
Avoid confusion by providing more context about the environment when the
script fails.
BEFORE:
AFTER: