Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression 0.32.6 - script_runner_args is not interpreted #471

Closed
Kreyren opened this issue Oct 7, 2020 · 3 comments
Closed

Regression 0.32.6 - script_runner_args is not interpreted #471

Kreyren opened this issue Oct 7, 2020 · 3 comments
Assignees
Milestone

Comments

@Kreyren
Copy link
Contributor

Kreyren commented Oct 7, 2020

Running

[env]
MESSAGE = "something"

# NOTICE(Krey): You will neeed quicklisp installed

[tasks.kreyren]
script_runner = "ecl"
script_runner_args = [ "--norc", "--quiet", "--shell" ]
script = [
'''
(write-line (ext:getenv "MESSAGE"))
'''
]

In cargo-make=0.32.6 results in:

kreyren@leonid:~/Repositories/kreyrock$ makers kreyren
[cargo-make] INFO - makers 0.32.6
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: kreyren
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: kreyren
Unknown command line option /tmp/kreyren/fsio/prB7DkDIPC.sh.

Usage: ecl [-? | --help]
           [--dir dir] [--load file] [--shell file] [--eval expr] [--rc | --norc]
           [--c-stack size] [--lisp-stack size] [--heap-size size] [--frame-stack size]
           [[-o ofile] [-c [cfile]] [-h [hfile]] [--data [datafile]] [-s] [-q]
            --compile file]
           [[-o ofile] --link file+]
           [--input-encoding external-format] [--output-encoding external-format]
           [--error-encoding external-format] [--encoding external-format]
           [--trap-fpe | --no-trap-fpe]
[cargo-make] ERROR - Error while executing command, exit code: 1
[cargo-make] WARN - Build Failed.

Where the same code worked on development branch.

Regression introduced in #464

@sagiegurari
Copy link
Owner

i lack docs, but you are missing script_extension. that should resolve it.

@sagiegurari
Copy link
Owner

I updated the docs a bit....
thanks for notifying me of this

@Kreyren
Copy link
Contributor Author

Kreyren commented Oct 8, 2020

@sagiegurari Works on my end with the script_extension, thanks! ^-^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants