Maybe should replace the cargo-script with rust-script

[umaYnit]

I tried to use cargo-script to write a build script, and My project was cross-compiled, so I tried to set a separate environment variable for cargo-script, but it still didn’t work. My script like this.

[tasks.hello]
env = { "CARGO_BUILD_TARGET" = "x86_64-pc-windows-msvc", "CARGO_MAKE_RUST_SCRIPT_PROVIDER" = "cargo-script" }
script_runner = "@rust"
script = '''
fn main() {
    println!("hello world!!");
}
'''

I checked the project and found this description:

Note: cargo-script does not work when Cargo is instructed to use a target architecture different to the default host architecture.

And the issue pointed out that the project is not very actived, rust-script is a maintained fork of cargo-script.
DanielKeep/cargo-script#71

[sagiegurari]

ya, i know of that. i also enable cargo play as an alternative.
if we are to replace to the fork, need to make sure its backwards compatible.
if it is, I'll do it, or a PR :)

[umaYnit]

I tried it, and there is basically no problem.
But because it supports "no main" mode, the judgment is simple now, so there may be problem if write like the following:

[tasks.hello]
script_runner = "@rust"
script = '''
     fn main() {
        println!("hello world!!");
    }
'''

[umaYnit]

And it not a cargo subcommand

[sagiegurari]

if its not a cargo subcommand it can still be used easily but will require a bit more code changes.

[sagiegurari]

rust-script is now supported. its not the default runner (just to make sure i do'nt break other projects for now)
so to enable it you need to add in the env:

[env]
CARGO_MAKE_RUST_SCRIPT_PROVIDER = "rust-script"

its currently in the 0.32.13 dev branch.

[sagiegurari]

@umaYnit once you verify this one is good for you, i'll publish a new cargo-make version with all the fixes i pushed based on your feedback
thanks a lot by the way!!! your feedback really helped me find some critical bugs.

[sagiegurari]

@umaYnit seems cargo-script is really broken so will make rust-script default after all

[sagiegurari]

@umaYnit since cargo-script was so broken lately, i decided to also release a new cargo make version already.
feel free to check it out and reopen/open issues. your feedback and PRs were great!

[umaYnit]

Execute compilation for the current project in rust-script, and the compiled product will be generated in the cache directory of rust-script, not the current project dir. test case:

[config]
skip_core_tasks = true

[tasks.build]
# env = { "CARGO_MAKE_RUST_SCRIPT_PROVIDER" = "cargo-script" }
script_runner = "@rust"
script = '''
fn main() {
    if !std::process::Command::new("cargo")
        .args(&["make", "_build"])
        .spawn()
        .unwrap()
        .wait()
        .unwrap()
        .success() { panic!() }
    println!("success");
}
'''

[tasks._build]
command = "cargo"
args = ["build", "--release"]

[sagiegurari]

is that an issue?

[sagiegurari]

i think cargo script did the same

[umaYnit]

cargo script not, will generated in project dir.

[sagiegurari]

strange. i always deleted some binary dir that cargo script created in the .cargo folder if i'm not wrong.
anyway, if this is configurable, i can pass it as part of the cli args.

[umaYnit]

I don’t see the relevant parameters in rust-script, maybe I should open an issue in rust-script.