Add CARGO_MAKE_CRATE_TARGET_DIR env variable
#548
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.32.17 #548 +/- ##
===========================================
+ Coverage 93.05% 93.07% +0.01%
===========================================
Files 98 98
Lines 19119 19132 +13
===========================================
+ Hits 17792 17807 +15
+ Misses 1327 1325 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@ark0f thanks a lot for the PR. this env var is actually super useful.
i see a test is failing so maybe worth to check what is the regression there.
docs/_includes/content.md
Outdated
| @@ -1431,6 +1431,7 @@ In addition to manually setting environment variables, cargo-make will also auto | |||
| * **CARGO_MAKE_RUST_TARGET_POINTER_WIDTH** - 32, 64 | |||
| * **CARGO_MAKE_RUST_TARGET_VENDOR** - apple, pc, unknown | |||
| * **CARGO_MAKE_RUST_TARGET_TRIPLE** - x86_64-unknown-linux-gnu, x86_64-apple-darwin, x86_64-pc-windows-msvc, etc ... | |||
| * **CARGO_MAKE_CRATE_TARGET_DIR** - Gets target directory where cargo stores the output of a build, respects ${CARGO_TARGET_DIR}, .cargo/config.toml's and ${CARGO_HOME}/config.toml, but not `--target-dir` command-line flag. | |||
There was a problem hiding this comment.
CARGO_MAKE_CRATE_TARGET_DIRECTORY please :)
src/lib/environment/mod.rs
Outdated
| ); | ||
|
|
||
| envmnt::set( | ||
| "CARGO_MAKE_CRATE_TARGET_DIR", |
There was a problem hiding this comment.
CARGO_MAKE_CRATE_TARGET_DIRECTORY
| .map(|config_file| config_file.join("config")) | ||
| .filter_map(|config_file| { |
There was a problem hiding this comment.
i'm guessing the regression might be here, but didn't investigate.
|
@ark0f also i merged your other PR, so you need to resolve merge conflicts |
…get-dir � Conflicts: � src/lib/environment/crateinfo.rs � src/lib/test/workspace2/Cargo.toml
|
@ark0f looks awesome. lets wait for the CI to finish and than i'll merge it. |
|
All tests pass after I added |
running cargo test will run tests in parallel so changing cwd will break other tests that look at the file system. |
|
Oops, forgot about import |
…in `crate_target_triple`
|
looks great. thanks again. merging |
No description provided.