Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcov should now only be run on test executables #555

Merged
merged 1 commit into from
May 3, 2021
Merged

kcov should now only be run on test executables #555

merged 1 commit into from
May 3, 2021

Conversation

elonca
Copy link

@elonca elonca commented Apr 29, 2021

During the coverage-flow, kcov is run on both test executables and project binaries (see #552).

The following changes keep the same initial set of binaries from the debug/deps directory, but removes from it the ones for which a copy exist in the debug directory. This way, the project binaries should now not be given to kcov.

The check for copies relies on GNU cmp which should be installed on all recent Linux and MacOS systems.

@sagiegurari
Copy link
Owner

thanks a lot for the PR. very interesting solution there. i'm kicking in the CI to see that it works well.

@sagiegurari sagiegurari self-assigned this Apr 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #555 (6df31a9) into master (30b6ba4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
- Coverage   93.01%   93.00%   -0.02%     
==========================================
  Files          98       98              
  Lines       19283    19283              
==========================================
- Hits        17936    17934       -2     
- Misses       1347     1349       +2     
Impacted Files Coverage Δ
src/lib/cli.rs 91.81% <0.00%> (-0.44%) ⬇️
src/lib/environment/mod.rs 92.95% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b6ba4...6df31a9. Read the comment docs.

@sagiegurari sagiegurari changed the base branch from master to 0.33.0 May 3, 2021 06:09
@sagiegurari
Copy link
Owner

@elonca thanks a lot for the PR, seems to work well :)
merging

@sagiegurari sagiegurari merged commit 93e0317 into sagiegurari:0.33.0 May 3, 2021
sagiegurari added a commit that referenced this pull request May 3, 2021
@elonca
Copy link
Author

elonca commented May 3, 2021

Good news !
Glad to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants