CARGO_MAKE_CRATE_TARGET_DIRECTORY does not respect workspace

[pheki]

Describe The Bug

If a crate is in a workspace, CARGO_MAKE_CRATE_TARGET_DIRECTORY will still be in the current directory instead of the root of the workspace

To Reproduce

• Create workspace directory and add project to it:

$ mkdir workspace
$ cd workspace
$ cargo new project

• Create virtual manifest for workspace, adding project to it

$ cat << EOF > Cargo.toml
[workspace]
members = ["project"]
EOF

• Add Makefile to print CARGO_MAKE_CRATE_TARGET_DIRECTORY (remove the additional \ before $ if you're editing the file manually)

$ cd project
$ cat << EOF > Makefile.toml
[env]
TARGET_DIR = "abc"

[tasks.print-target-dir]
script = '''
echo Target Dir: \${CARGO_MAKE_CRATE_TARGET_DIRECTORY}
'''
EOF

• Run print-target-dir task for project

$ cargo make print-target-dir

Output

$ cargo make print-target-dir
[cargo-make] INFO - cargo make 0.32.17
[cargo-make] INFO - Project: project
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: print-target-dir
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: print-target-dir
Target Dir: target
[cargo-make] INFO - Build Done in 0.03 seconds.

Found target: (equivalent to) /path/to/workspace/project/target
Expected target: /path/to/workspace/target

The expected target can be found by running cargo metadata, in key target_directory:

$ cargo metadata --format-version 1 --no-deps

(Possible) Solution

I would personally suggest using cargo metadata to get the target directory, instead of trying to guess it by manually looking at the environment.

[sagiegurari]

@pheki thanks a lot for the feedback :)

@ark0f worth to check suggestion from @pheki before pushing #554
i actually already trigger cargo metadata as part of the flow so we can use this info as suggeted.

[ark0f]

@ark0f worth to check suggestion from @pheki before pushing #554

Really good suggestion, already in PR

[pheki]

Fixed by #554 (thanks!)