Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Cargo.lock in the repository / release tarballs #670

Closed
jirutka opened this issue Jul 20, 2022 · 4 comments
Closed

Missing Cargo.lock in the repository / release tarballs #670

jirutka opened this issue Jul 20, 2022 · 4 comments
Assignees
@sagiegurari
Labels
enhancement
Milestone
0.35.14

Comments

@jirutka
Copy link
Contributor

jirutka commented Jul 20, 2022

Please include Cargo.lock in the repository and keep it up-to-date when releasing new versions. It’s important for (linux) distributions to ensure reproducible builds.
@sagiegurari
Copy link
Owner

I'm not sure cargo-make is packaged by any linux dist. could be wrong.

@jirutka
Copy link
Contributor Author

jirutka commented Jul 20, 2022

You are wrong… https://repology.org/project/cargo-make/versions. ;) And I’m currently packaging it for Alpine Linux.

@sagiegurari
Copy link
Owner

oh wow. nice. any chance you can also do some PR to update the docs and put some installation instructions using package managers for relevant dists?

sagiegurari added a commit that referenced this issue Jul 21, 2022
@sagiegurari
Cliparse (#671)
532a239 
* Enhancement: CLI parsing now done by the cliparser crate instead of clap due to clap continued backward compatibility issues
* Enhancement: Check in Cargo.lock file to support linux package managers #670
@sagiegurari sagiegurari added this to the 0.35.14 milestone Jul 21, 2022
@sagiegurari
Copy link
Owner

this is now officially released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagiegurari sagiegurari

Labels
enhancement
Projects
None yet
Milestone
0.35.14
Development

No branches or pull requests
2 participants
@jirutka @sagiegurari