Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Lint-Staged for Prettier and ESLint #1171

Open
nirmalhk7 opened this issue Oct 6, 2021 · 3 comments
Open

Implementing Lint-Staged for Prettier and ESLint #1171

nirmalhk7 opened this issue Oct 6, 2021 · 3 comments

Comments

@nirmalhk7
Copy link

I'd like to know if we should implement lint-staged in package.json: that way we'll be able to lint and prettify all files which are being changed.

If you deem this as a good idea, I'd like to take this up 馃槃

@sahat
Copy link
Owner

sahat commented Mar 26, 2022

That's a good idea.

@YasharF
Copy link
Collaborator

YasharF commented Jul 13, 2023

Added lint-stage with husky: 0407289

I'm skipping prettier for now because its out-of-the-box rules are in conflict with the current lint rules. We would either need to restyle the entire project and change the current lint rules and/or add a bunch of overrides in .prettierrc to match the current style. @sahat let me know which way you would want to go.

Repository owner deleted a comment Aug 10, 2023
@umangpatel8123
Copy link

.prettierrc.json is also a good idea instead of eslint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants