New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm build
fails with the react-storefront
sources of commit ca66031ba017d1839f4653deef00830052d01f8e
#399
Comments
Thank you for taking the time to write this report, we really appreciate it! We'll look into this issue but my first guess would be either nodejs or pnpm versions incompatibility. Could you make sure your pnpm lock file is unmodified? It would be great if you could also provide full output log. Thanks! |
You're welcome @mmiszy and thank you too for the feedback. It also happens with node 16, specifically with version With
My local file @mmiszy do you know of a way to keep the original |
Thank you! Yes, you need to run |
Thank you @mmiszy. This is the error output I'm getting when running
|
Just for reference, this is the output I'm getting when running
|
Hello everybody. I found a way to avoid the reported error, by means of editing the file
to this other one:
I tested it with Node.js 18 on Ubuntu 22.04, with the Some related observations to better understand the situation:
Given all of the above, could you please check what source code or documentation change may be applied to Thanks again. |
We require Unfortunately, I couldn't reproduce the problem locally. |
Hello @mmiszy. Based on your feedback I gathered these observations when running, or trying to run, the
For reference, this is the final output of running the
It's worth mentioning that no local source code modifications have been applied to the Summary:
Regards. |
This seems to be caused by this pnpm bug, which was introduced after 7.5.2. Unfortuneatly, Vercel now uses a newer version of pnpm, so it's impossible to deploy to vercel without a fix. As a workaround, I disabled auto-install-peers at a project level, then reinstalled to regenerate the lockfile by reinstalling, and committed the result.
This may be hard to reproduce even on newer pnpm versions if auto-install-peers is already off by default on your machine for some reason. |
Thank you @jamesknelson. I have not played with For my local purposes, I can continue using pnpm version 7.5.2. Is there other thing to consider? If not, maybe we can close this issue, unless someone from the Saleor team thinks different. Regards. |
We're moving forward with enabling |
Hello. The initial reported issue no longer happens with some combination of these:
In case that no other improvements are considered, this issue can be closed. Regards. |
Fixed in #458 |
Summary
When running the command
pnpm build
I'm receiving a failure that shows this output at the end:My system runs with these elements:
react-storefront
commit ID isca66031ba017d1839f4653deef00830052d01f8e
Steps to reproduce
react-storefront
repository..env
file as needed.pnpm i
command.pnpm build
command inside thereact-storefront
directory.A link to a reproduction repository
No response
Output from envinfo
No response
The text was updated successfully, but these errors were encountered: