Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Project for use by Typescript Libraries #217

Open
awaterma opened this issue Aug 16, 2021 · 2 comments
Open

Enable Project for use by Typescript Libraries #217

awaterma opened this issue Aug 16, 2021 · 2 comments
Assignees
Projects

Comments

@awaterma
Copy link
Member

We think it would be a good idea to enable this project for use with typescript. We'd want to do this in chunks over time, or in a large pull request that could be reviewed by the team.

https://www.typescriptlang.org/docs/handbook/migrating-from-javascript.html

@wjhsf
Copy link
Contributor

wjhsf commented Dec 17, 2021

@types/tough-cookie exists as a community effort. We can definitely provide our own type definitions eventually, but it doesn't necessarily need to be prioritized.

@awaterma
Copy link
Member Author

From discussion, it looks like @types/tough-cookie is only supplying types for the Callback versions of our API. So, we may want to invest some effort here to make this clearer in that project, or bundle our own, as we suggest at the top.

@colincasey has committed to take a deeper look at this issue for us.

@awaterma awaterma added this to To do in 4.2 Release via automation Mar 21, 2022
wjhsf pushed a commit that referenced this issue Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants