Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindCookies function inside memstore.js does not catch the error thrown by permuteDomain function. #272

Open
dev-sharma-08 opened this issue Apr 12, 2023 · 2 comments
Open

FindCookies function inside memstore.js does not catch the error thrown by permuteDomain function. #272

dev-sharma-08 opened this issue Apr 12, 2023 · 2 comments

Comments

@dev-sharma-08
Copy link

permuteDomain fn calls getPublicSuffix fn from pubsuffix-psl.js file which throws error upon using SPECIAL_USE_DOMAINS.
This error is not handled anywhere which causes unintended crashes.
@wjhsf
Copy link
Contributor

wjhsf commented Apr 12, 2023

Hi @dev-sharma-08, thanks for reporting this issue. findCookies has a parameter allowSpecialUseDomain that will change the behavior to avoid throwing errors when special use domains are used. If the error still occurs when you set that flag, please provide detailed steps to reproduce so that we can properly investigate. Thanks!

@dev-sharma-08
Copy link
Author

dev-sharma-08 commented Apr 13, 2023 •
edited

Hi @wjhsf, thanks for the quick reply. But even when allowSpecialDomain is set as true but if the domain part length is less than one, it throws error.

wjhsf pushed a commit that referenced this issue Feb 8, 2024
@jye-sf
chore: remove old workflow @W-10946336 (#272)
fd2cbad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wjhsf @dev-sharma-08