Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and prune lock files #120

Closed
2 tasks done
novellizator opened this issue Mar 16, 2020 · 5 comments · Fixed by #123
Closed
2 tasks done

Update dependencies and prune lock files #120

novellizator opened this issue Mar 16, 2020 · 5 comments · Fixed by #123
Assignees

Comments

@novellizator
Copy link
Contributor

novellizator commented Mar 16, 2020

https://github.com/salsita/foosball-rating/network/alerts points to the problems and they are two fold.

  • deps need to be updated

  • we seem to be using both package-lock and yarn-lock. Let's delete one of them (and put it in gitignore) and be consistent

@novellizator novellizator changed the title Update dependencies and prune lock files. Update dependencies and prune lock files Mar 16, 2020
@littlewhywhat
Copy link
Contributor

littlewhywhat commented Mar 17, 2020

so at the current moment there are alerts regarding minimist 0.0.8 for root and backend package.json files.
For root package.json:

├─┬ eslint@6.8.0
│ └─┬ mkdirp@0.5.1
│   └── minimist@0.0.8 

comes from eslint 6.8.0 and it's the latest release of eslint - it actually uses this old version of mkdirp https://github.com/eslint/eslint/blob/v6.8.0/package.json#L75

should be resolved with this one eslint/eslint#13050 - then we can update eslint or we can wait for dependabot to do... :)

@littlewhywhat
Copy link
Contributor

for backend/package.json:

└─┬ node-pg-migrate@4.2.2
  └─┬ mkdirp@0.5.1
    └── minimist@0.0.8 

Used by node-pg-migrate as you see but actually this is strange for me because the package uses ~1.0.0 of mkdirp - https://github.com/salsita/node-pg-migrate/blob/master/package.json#L48 that doesn't use minimist at all https://github.com/isaacs/node-mkdirp/blob/v1.0.0/package.json... I tried to reinstall but still I get old mkdirp in package-lock.json.

@littlewhywhat
Copy link
Contributor

littlewhywhat commented Mar 17, 2020

for node-pg-migrate - the problem is that in tgz package we still use mkdirp 0.5.0 therefore npm keeps installing it with minimist.

@littlewhywhat littlewhywhat linked a pull request Mar 17, 2020 that will close this issue
littlewhywhat added a commit that referenced this issue Mar 23, 2020
- Update node-pg-migrate
- Reinstall eslint
- npm audit fix for ts-jest
littlewhywhat added a commit that referenced this issue Mar 23, 2020
gh-120: Update node-pg-migrate, remove unused nedb
littlewhywhat added a commit that referenced this issue Mar 23, 2020
@littlewhywhat littlewhywhat reopened this Mar 23, 2020
@littlewhywhat
Copy link
Contributor

still need to run npm audit fix in frontend and root folders

littlewhywhat added a commit that referenced this issue Mar 23, 2020
@littlewhywhat
Copy link
Contributor

fixed by #134 and #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants