fix: restore support url as an object in configuration #1119
Conversation
jraoult
changed the title
jraoult
changed the title
|
Uhm... this might be nice what you had done with Instead you should just add one test-job to https://github.com/salsita/node-pg-migrate/blob/main/.github/workflows/postgres-test.yml like node-pg-migrate/.github/workflows/postgres-test.yml Lines 90 to 126 in 6e5b6df |
@Shinigami92 Hmm fair enough. I missed that. Let me see if I can hack that today, but it might be tight. Otherwise, I'll take care of it next week. |
@Shinigami92, back at it. So, do you want a complete job or to add steps to the existing one? My instinct was to just add two steps, like "Write alternative config" and then "Integration Test for alternate config" since it would save execution time (no need to reinstall and rebuild). Also, did you mean to run a full migration test (ie. |
complete job / copy of "Config Test"
it's ok to do a full/real migration like "Config Test" |
jraoult
force-pushed
the
fix/1112-support-url-as-an-object
branch
from
5dd247a
to
80f6ac2
Compare
|
@Shinigami92 done 👍 |
|
You could name these like "Config 1 Test" and "Config 2 Test", because we already have something similar with "Password 1 Test" and "Password 2 Test" |
|
🎉 thx for your contribution 🙏 |
|
v7.2.1 released |
This PR fixes a regression introduced in
v7.0.0where it was not possible to use the defined configuredurlas an object anymore (cf. https://salsita.github.io/node-pg-migrate/#/cli?id=json-configuration).For reference, it typically looks like that:
{ "url": { "connectionString": "postgres://postgres:password@localhost:5432/postgres", "ssl": false } }This was caused by a lack of unit testing around this behaviour, so I introduced a spec for the CLI to cover this case. I never had to write tests for CLIs @Shinigami92, so I had to improvise a little. I think it is a good base to extend the CLI tests if you ever want to. Let me know what you think.
Closes #1112