Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo is not done in a single transaction #912

Open
ocadoret opened this issue Sep 19, 2022 · 0 comments
Open

redo is not done in a single transaction #912

ocadoret opened this issue Sep 19, 2022 · 0 comments

Comments

@ocadoret
Copy link

The redo action does not execute all migrations in a single transaction like the up and down actions. It perfoms the migrations with 2 separated transactions :

  • one transaction for the down migrations
  • one transaction for the up migrations

So, if an error occurs while performing the "up" migrations, the "down" migrations are committed, without a message indicating that. So if you try to execute again the redo, it will migrate down more migrations before migrating up.

redo action should have the same behaviour as the up and down actions, any errors should also rollback the "down" migrations when an error occurs in the "up" migrations, and leave the database untouched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant