Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React-Dom dependency requires SharedArrayBuffer which will require cross-origin isolation #119

Closed
FizzBuzz791 opened this issue Apr 14, 2021 · 2 comments
Closed

React-Dom dependency requires SharedArrayBuffer which will require cross-origin isolation #119

FizzBuzz791 opened this issue Apr 14, 2021 · 2 comments

Comments

@FizzBuzz791
Copy link

See this issue for more information; facebook/react#20829

The tl;dr is that people could start running into problems quite soon (May 2021!). This has been fixed in React 17+ and upgrading the react-dom dependency of this package, should also resolve this issue.
@salvoravida
Copy link
Owner

react-dom is not needed for react-adal. it's just a dev dep

@FizzBuzz791
Copy link
Author

@salvoravida - I think this call stack indicates otherwise...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FizzBuzz791 @salvoravida