Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal timeout does not propagate #258

Open
yli02 opened this issue Feb 5, 2024 · 2 comments
Open

Signal timeout does not propagate #258

yli02 opened this issue Feb 5, 2024 · 2 comments
Labels

Comments

@yli02
Copy link

yli02 commented Feb 5, 2024

Description

The values of sigint_timeout and sigkill_timeout of function

def run_process(

don't propagate to line
process.stop()

Example Code

Watchfiles Output

[15:25:44] watchfiles v0.21.0 👀 path="/mnt/c/Users/yli2/workspace/******" target="echo reloaded" (command) filter=DefaultFilter...
[15:25:44] running "echo reloaded" as command
[15:25:44] registering handler for SIGTERM on watchfiles process 13943
reloaded
watcher: PollWatcher { watches: Mutex { data: , poisoned: false, .. }, data_builder: Mutex { data: , poisoned: false, .. }, want_to_stop: false, delay: 300ms }
[15:26:00] rust notify timeout, continuing
[15:26:05] rust notify timeout, continuing

Operating System & Architecture

Linux-5.15.133.1-microsoft-standard-WSL2-x86_64-with-glibc2.35

Environment

docker, WSL

Python & Watchfiles Version

python: 3.8.18 (default, Aug 25 2023, 13:20:30) [GCC 11.4.0], watchfiles: 0.21.0

Rust & Cargo Version

No response

@yli02 yli02 added the bug label Feb 5, 2024
@yli02
Copy link
Author

yli02 commented Feb 6, 2024

Hi @samuelcolvin, may I get your feedback about this issue? Thanks.

@yli02
Copy link
Author

yli02 commented Feb 6, 2024

Hi @samuelcolvin, I am not sure whether it is appropriate to classify this as a bug, it do seem that the PR for issue #152 left/forgot about

process.stop()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant