Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make a new release using pyo3 0.20.3 #261

Open
mgorny opened this issue Feb 24, 2024 · 7 comments
Open

Please make a new release using pyo3 0.20.3 #261

mgorny opened this issue Feb 24, 2024 · 7 comments
Labels

Comments

@mgorny
Copy link
Contributor

mgorny commented Feb 24, 2024

Description

The current PyO3 version of 0.20.0 is broken on PowerPC (PyO3/pyo3@9d1b11f). This is preventing PowerPC users from installing watchfiles cleanly.

Could you update PyO3 and make a new release, please?

Example Code

No response

Watchfiles Output

No response

Operating System & Architecture

Linux-6.1.60-gentoo-dist-hardened-ppc-POWER9_-architected-,_altivec_supported-with-glibc2.38
#1 SMP Fri Dec 1 22:10:49 UTC 2023

Environment

No response

Python & Watchfiles Version

n/a (not installable)

Rust & Cargo Version

cargo 1.74.1 (ecb9851af 2023-10-18); rustc 1.74.1 (a28077b28 2023-12-04)

@mgorny mgorny added the bug label Feb 24, 2024
@gaby
Copy link

gaby commented May 4, 2024

@mgorny
Copy link
Contributor Author

mgorny commented May 4, 2024

Nope. Cargo.lock says 0.20.0.

@gaby
Copy link

gaby commented May 4, 2024

@samuelcolvin Any chance to get a new release with update dependencies. PyO3 is already on v0.21.x

Probably worth adding dependabot.yml to the repo.

@samuelcolvin
Copy link
Owner

PR welcome, otherwise I'll try soon.

@gaby
Copy link

gaby commented May 4, 2024

I was going to update them, then realize PyO3 v0.21.x changed the API and I dont know Rust 😂

I cam submit one for dependabot config

@mgorny mgorny mentioned this issue May 5, 2024
@samuelcolvin
Copy link
Owner

All updates are complete, watchfiles now uses latest pyo3, and i've updated actions version.

@gaby and @mgorny please try the latest version from main and confirm you're happy, then I'll do a release.

@mgorny
Copy link
Contributor Author

mgorny commented May 8, 2024

Yeah, I can confirm main now builds on PowerPC and has no PPC-specific test regressions. However, it is still affected by #254. But I'm happy to just skip that test, if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants