fix: throw DtsError with errors only #221
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if doExtract fails it throws an error including every message received during build, including warnings that are ignored by the current loglevel/package config. Combined with another issue that does't render error messages properly (not exactly sure where this happens, didn't dig into it), but rather console.logs the array of messages, the actual errors gets obscured by other messages (info, warnings, etc.) which in turn makes it hard to track down exactly what failed. This fixes this particular issue by making sure only _errors_ are attached to the thrown exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
doExtractfails it throws an error including every message received during build, including warnings that are ignored by the current loglevel/package config. Combined with another issue that does't render error messages properly (not exactly sure where this happens, didn't dig into it), but rather console.logs the array of messages, the actual errors gets obscured by other messages (info, warnings, etc.) which in turn makes it hard to track down exactly what failed. This fixes this particular issue by making sure only errors are attached to the thrown exception.