fix: allow dynamicImportInCjs in rollup v3
#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
force-pushed
the
fix-allow-dynamicImportInCjs-in-rollup-v3
branch
from
aaaedd8 to
df674d6
Compare
stipsan
force-pushed
the
fix-allow-dynamicImportInCjs-in-rollup-v3
branch
from
df674d6 to
ebedbea
Compare
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup v3 introduces a great new option called
dynamicImportInCjs.Since we target Node 14 as our baseline we can safely use code like this:
And if
pkgis ESM-only (no CJS exports) it'll work the same in both ESM and CJS in NodeJS environments.However since we use
@babel/preset-envthis new option doesn't work as babel is transforming the dynamicimport()calls torequire().This PR fixes that by turning module transformation off in babel.