fix: disable transitive imports hoisting #29
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
force-pushed
the
fix-disable-transitive-imports-hoisting
branch
from
3635032 to
435c3d2
Compare
mariuslundgard
approved these changes
Jan 2, 2023
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As packages consumed by
pkg-utilsare typically consumed by other bundlers this optimization is a bit counter-intuitive.For example look at: https://unpkg.com/browse/next-sanity@3.1.8/dist/studio/index.js
And line 17-18:
This happens because the file that uses
@sanity/iconsand@sanity/uiisNextStudioLoading. AndNextStudioLoadingis used bydist/studio/index.jsanddist/studio/loading.js.More info.