Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No feedback when api requests fail #2

Open
edenstrom opened this issue Nov 27, 2019 · 1 comment
Open

No feedback when api requests fail #2

edenstrom opened this issue Nov 27, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@edenstrom
Copy link

Current behavior

When choosing an image, and the request fails for some reason, no feedback is given to the user.

Expected behavior

Some feedback that the request failed.

Reproduction

  • Install Privacy Badger
  • Open Select From -> Unsplash
  • In Privacy Badger, block images.unsplash.com
  • Choose image
  • Error is logged in console, but no feedback is given to user

Environment

Software Version
@sanity/core 0.146.3
@sanity/desk-tool 0.146.3
sanity-plugin-asset-source-unsplash 0.1.1

PS. Really good work with the pluggable asset sources. Really cool 💯
@kmelve
Copy link
Member

kmelve commented Nov 27, 2019 •
edited

This makes sense. Thanks for reporting!

@kmelve kmelve added the enhancement New feature or request label Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmelve @edenstrom