Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added attribution data to the asset #7

Closed
wants to merge 2 commits into from
Closed

Added attribution data to the asset #7

wants to merge 2 commits into from

Conversation

marekbrze
Copy link

Fixes #6

@robinpyon
Copy link

Hey @marekbrze, thanks for the contribution!

Were you able to test and verify this locally?

From what I gather – this shouldn't work as Sanity will only accept a set of whitelisted props in assetDocumentProps when calling props.onSelect.

Any other custom props (user in this case) will be omitted when props.onSelect is called (and when the image is subsequently uploaded). This is probably in place to ensure that users aren't uploading images to Sanity with huge custom payloads.

@marekbrze
Copy link
Author

Hi, sorry I didn't check it that well. I assume that the only available option is to change what's in creditLine or ask Sanity to add "author" field to store at least the author full name.

@marekbrze marekbrze closed this Jan 27, 2022
@robinpyon
Copy link

No problem! Let's keep the issue open as it's still very much a reasonable ask.

I'll raise the possibility of custom asset sources being able to store more props with the team.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide more info about the author from the API
2 participants