Skip to content

Commit 4ae88a0

Browse files
authoredMar 4, 2024
fix(portable-text-editor): all paths must be checked (#5891)
* fix(portable-text-editor): all paths must be checked This optimization was a bit too optimistic. It's causing issues with some type of selections. Check every path here. * fix(portable-text-editor): allow uncollapsed ranges Uncollapsed ranges must be allowed as they may be pointing to empty blocks
1 parent ed87e2a commit 4ae88a0

File tree

1 file changed

+2
-4
lines changed
  • packages/@sanity/portable-text-editor/src/editor

1 file changed

+2
-4
lines changed
 

‎packages/@sanity/portable-text-editor/src/editor/Editable.tsx

+2-4
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable(
249249
const newSlateRanges: BaseRangeWithDecoration[] = []
250250
rangeDecorations.forEach((rangeDecorationItem) => {
251251
const slateRange = toSlateRange(rangeDecorationItem.selection, slateEditor)
252-
if (!SlateRange.isRange(slateRange) || !SlateRange.isExpanded(slateRange)) {
252+
if (!SlateRange.isRange(slateRange)) {
253253
if (rangeDecorationItem.onMoved) {
254254
rangeDecorationItem.onMoved({
255255
newSelection: null,
@@ -574,9 +574,7 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable(
574574
},
575575
]
576576
}
577-
const result = rangeDecorationState.filter(
578-
(item) => path.length > 1 && SlateRange.includes(item, path),
579-
)
577+
const result = rangeDecorationState.filter((item) => SlateRange.includes(item, path))
580578
if (result.length > 0) {
581579
return result
582580
}

0 commit comments

Comments
 (0)
Please sign in to comment.