Skip to content

Commit 63432da

Browse files
authoredMar 20, 2024
refactor(codegen): move Result appending into type generation (#6082)
1 parent 7402093 commit 63432da

File tree

3 files changed

+5
-19
lines changed

3 files changed

+5
-19
lines changed
 

‎packages/@sanity/codegen/src/typescript/__tests__/findQueriesInSource.test.ts

+2-16
Original file line numberDiff line numberDiff line change
@@ -74,19 +74,6 @@ describe('findQueries', () => {
7474
expect(queries.length).toBe(0)
7575
})
7676

77-
test("should name queries with 'Result' at the end", () => {
78-
const source = `
79-
import { groq } from "groq";
80-
const postQuery = groq\`*[_type == "author"]\`
81-
const res = sanity.fetch(postQueryResult);
82-
`
83-
84-
const queries = findQueriesInSource(source, 'test.ts')
85-
const queryResult = queries[0]
86-
87-
expect(queryResult?.name.substr(-6)).toBe('Result')
88-
})
89-
9077
test('should import', () => {
9178
const source = `
9279
import { groq } from "groq";
@@ -106,8 +93,7 @@ describe('findQueries', () => {
10693
}
10794

10895
const queries = findQueriesInSource(source, 'test.ts', undefined, resolver)
109-
const queryResult = queries[0]
110-
111-
expect(queryResult?.name.substr(-6)).toBe('Result')
96+
expect(queries.length).toBe(1)
97+
expect(queries[0].result).toBe('*[_type == "foo"]')
11298
})
11399
})

‎packages/@sanity/codegen/src/typescript/findQueriesInSource.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export function findQueriesInSource(
4646
babelTypes.isIdentifier(node.id) &&
4747
init.tag.name === groqTagName
4848
) {
49-
const queryName = `${node.id.name}Result`
49+
const queryName = `${node.id.name}`
5050
const queryResult = resolveExpression({
5151
node: init,
5252
file,

‎packages/sanity/src/_internal/cli/threads/typegenGenerate.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,10 @@ async function main() {
9595
const ast = parse(query)
9696
const queryTypes = typeEvaluate(ast, schema)
9797

98-
const type = typeGenerator.generateTypeNodeTypes(queryName, queryTypes)
98+
const type = typeGenerator.generateTypeNodeTypes(`${queryName}Result`, queryTypes)
9999

100100
fileQueryTypes.push({
101-
queryName: queryName,
101+
queryName,
102102
query,
103103
type,
104104
unknownTypes: countUnknownTypes(queryTypes),

0 commit comments

Comments
 (0)
Please sign in to comment.