fix(pte): updates zoffset for PopoverEditDialog to not be on top of InspectDialog (#5882)

jtpetty · web-flow · commit 69b355289767 · 2024-03-08T14:36:53.000Z
* fix(pte): updates zoffset for PopoverEditDialog to not be on top of InspectDialog

* fix(pte): update to use new default instead of hardcoding zoffset

* fix(core): add missing file
diff --git a/packages/sanity/src/core/components/zOffsets/defaults.ts b/packages/sanity/src/core/components/zOffsets/defaults.ts
@@ -13,6 +13,7 @@ export const defaults: ZIndexContextValue = {
   paneHeader: [110, 15000],
   paneFooter: [120, 20000],
   paneResizer: [130, 25000],
+  paneDialog: [140, 5000],
 
   //
   popover: 200,
diff --git a/packages/sanity/src/core/components/zOffsets/types.ts b/packages/sanity/src/core/components/zOffsets/types.ts
@@ -14,6 +14,7 @@ export interface ZIndexContextValue {
   paneHeader: number | number[]
   paneFooter: number | number[]
   paneResizer: number | number[]
+  paneDialog: number | number[]
 
   /** Used by: EditItemFoldOut, Spinner, ConnectorsOverlay, tippy.css, BaseDateTimeInput */
   portal: number | number[]
diff --git a/packages/sanity/src/structure/panes/document/document-layout/DocumentLayout.tsx b/packages/sanity/src/structure/panes/document/document-layout/DocumentLayout.tsx
@@ -195,7 +195,7 @@ export function DocumentLayout() {
         >
           <DocumentPanelHeader ref={setHeaderElement} menuItems={menuItems} />
 
-          <DialogProvider position={DIALOG_PROVIDER_POSITION} zOffset={zOffsets.portal}>
+          <DialogProvider position={DIALOG_PROVIDER_POSITION} zOffset={zOffsets.paneDialog}>
             <Flex direction="column" flex={1} height={layoutCollapsed ? undefined : 'fill'}>
               <StyledChangeConnectorRoot
                 data-testid="change-connector-root"

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ export function DocumentLayout() {`
`195`	`195`	`>`
`196`	`196`	`<DocumentPanelHeader ref={setHeaderElement} menuItems={menuItems} />`
`197`	`197`
`198`		`- <DialogProvider position={DIALOG_PROVIDER_POSITION} zOffset={zOffsets.portal}>`
	`198`	`+ <DialogProvider position={DIALOG_PROVIDER_POSITION} zOffset={zOffsets.paneDialog}>`
`199`	`199`	`<Flex direction="column" flex={1} height={layoutCollapsed ? undefined : 'fill'}>`
`200`	`200`	`<StyledChangeConnectorRoot`
`201`	`201`	`data-testid="change-connector-root"`