Skip to content

Commit 7d3f33d

Browse files
skogsmaskinhermanwikner
andauthoredMar 6, 2024
chore(comments): enable inline comments (#5883)
* chore(comments): enable inline comments * fix(comments): remove comment in plugin * test(comments): remove comment in e2e test --------- Co-authored-by: Herman Wikner <wiknerherman@gmail.com>
1 parent 4acc11e commit 7d3f33d

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed
 

‎packages/sanity/src/structure/comments/plugin/index.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {definePlugin} from 'sanity'
33
import {commentsUsEnglishLocaleBundle} from '../i18n'
44
import {CommentsDocumentLayout} from './document-layout'
55
import {CommentsField} from './field'
6-
// import {CommentsInput} from './input'
6+
import {CommentsInput} from './input'
77
import {commentsInspector} from './inspector'
88
import {CommentsStudioLayout} from './studio-layout'
99

@@ -20,8 +20,7 @@ export const comments = definePlugin({
2020
form: {
2121
components: {
2222
field: CommentsField,
23-
// The `CommentsInput` will be enabled when it is ready to be used.
24-
// input: CommentsInput,
23+
input: CommentsInput,
2524
},
2625
},
2726

‎test/e2e/tests/comments/inline.spec.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,15 @@ async function inlineCommentCreationTest(props: InlineCommentCreationTestProps)
8484
await expect(commentsListItemReferencedValue).toHaveText(PTE_CONTENT_TEXT)
8585
}
8686

87-
// The tests will be enabled when the inline comments feature is ready to be used.
8887
test.describe('Inline comments:', () => {
89-
test.skip('should create inline comment', async ({page, createDraftDocument, browserName}) => {
88+
test('should create inline comment', async ({page, createDraftDocument, browserName}) => {
9089
// For now, only test in Chromium due to flakiness in Firefox and WebKit
9190
test.skip(browserName !== 'chromium')
9291

9392
await inlineCommentCreationTest({page, createDraftDocument})
9493
})
9594

96-
test.skip('should resolve inline comment', async ({page, createDraftDocument, browserName}) => {
95+
test('should resolve inline comment', async ({page, createDraftDocument, browserName}) => {
9796
// For now, only test in Chromium due to flakiness in Firefox and WebKit
9897
test.skip(browserName !== 'chromium')
9998

0 commit comments

Comments
 (0)
Please sign in to comment.